clintropolis commented on PR #16849: URL: https://github.com/apache/druid/pull/16849#issuecomment-2623266513
>I think this PR broke dataSourceMetadata query. Seems like MaxIngestedEventTimeInspector in DataSourceMetadataQueryRunner will always be null. The intention of the new `MaxIngestedEventTimeInspector` is that it is only for use with realtime data, because every other implementation on the old `StorageAdapter` of `getMaxIngestedEventTime()` was just calling `getMaxTime()` which gives the end interval of the segment. Could use `timeBoundary` instead if there is no realtime data. It does seem odd we return min datetime, i would have expected null. I don't think it makes much sense to have an implementation of `MaxIngestedEventTimeInspector` for published segments given that `timeBoundary` exists, but the docs could probably more clearly spell this out. Apologies for the behavior change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
