maytasm commented on PR #16849:
URL: https://github.com/apache/druid/pull/16849#issuecomment-2623279128
@clintropolis
Thanks for the response.
- Im a little confused on when you said that getMaxTime() gives the end
interval of the segment. I believe that this query (dataSourceMetadata) was
previously returning something like `2025-01-21T08:23:32.096Z` for our
non-realtime datasource. The code for getMaxTime() in
QueryableIndexStorageAdapter looks something like:
```
private void populateMinMaxTime()
{
// Compute and cache minTime, maxTime.
final ColumnHolder columnHolder =
index.getColumnHolder(ColumnHolder.TIME_COLUMN_NAME);
try (NumericColumn column = (NumericColumn) columnHolder.getColumn()) {
this.minTime = DateTimes.utc(column.getLongSingleValueRow(0));
this.maxTime =
DateTimes.utc(column.getLongSingleValueRow(column.length() - 1));
}
}
```
which does seems to return the actual time (min and max) of the rows/data
(not the end interval of the segment)... unless I am missing something.
- Given that the intention of the new MaxIngestedEventTimeInspector is for
only realtime data, is it still fair to say that the dataSourceMetadata query
should still work for non-realtime datasource (as it was previously working for
non-realtime datasources)?
- It is returning min datetime as currMaxIngestedEventTime is null at:
https://github.com/apache/druid/blob/master/processing/src/main/java/org/apache/druid/query/datasourcemetadata/DataSourceMetadataQuery.java#L109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
