clintropolis opened a new pull request, #17803:
URL: https://github.com/apache/druid/pull/17803

   ### Description
   changes:
   * `CompactionTask` now accepts a `projections` property which will cause 
classic and MSQ auto-compaction to build segments with projections
   * `DataSourceCompactionConfig` has been turned into an interface, with the 
existing implementation renamed to `InlineSchemaDataSourceCompactionConfig`
   * Added projections list to `InlineSchemaDataSourceCompactionConfig` to 
allow explicitly defining projections in an inline schema compaction spec
   * if not explicitly defined, compaction tasks will now preserve existing 
projections when processing segments, combining all named projections across 
the segments being processed - different projections with the same name are not 
checked for equivalence, rather one will be chosen dependent on segment 
processing order.
   * Added ability to define projections as a property of a datasource in the 
catalog
   * If projections are defined in a catalog, they will be automatically used 
by MSQ insert and replace queries
   * Added new experimental `CatalogDataSourceCompactionConfig` which allows 
populating much of a `CompactionTask` using information stored in the catalog. 
Currently this has some feature gaps compared to 
`InlineSchemaDataSourceCompactionConfig`, but will be improved in follow-up 
work to eventually become much more powerful than what can be expressed via a 
`InlineSchemaDataSourceCompactionConfig`
   * Moved `MetadataCatalog` to druid-server from the catalog extension
   * Added method to get `MetadataCatalog` from `CatalogResolver`
   * Added `CatalogCoreModule` to provide a null binding for `MetadataCatalog`, 
overridden if the catalog extension is loaded
   * Overlord added as a watcher for catalog like the Broker so that it can 
have `CatalogResolver` and `MetadataCatalog` available
   * Added binding for `MetadataCatalog` to Coordinator to have 
`MetadataCatalg` available
   
   
   #### Release note
   _todo_
   
   <hr>
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items apply to every PR. Remove the items which are not done or 
not relevant to the PR. None of the items from the checklist below are strictly 
necessary, but it would be very helpful if you at least self-review the PR. -->
   
   This PR has:
   
   - [ ] been self-reviewed.
      - [ ] using the [concurrency 
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
 (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] a release note entry in the PR description.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked 
related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in 
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to