clintropolis commented on code in PR #17803:
URL: https://github.com/apache/druid/pull/17803#discussion_r2022402999
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java:
##########
@@ -1086,6 +1130,60 @@ private void processMultiValuedDimensions(final
QueryableIndex index)
}
}
+
+ private void processProjections(final QueryableIndex index)
Review Comment:
added.
This got me thinking a bit though about what behavior would be better
between using the first encountered vs the last encountered? Should it warn if
there is a mismatch? Right now it is using last encountered, but i didn't give
it a lot of thought, since the main goal for this discovery based stuff was for
compaction to not automatically wipe out projections by default. My preference
is that this will all be driven via the catalog instead of relying on discovery
from segments, but this at least covers that case where the setup was not done
(or not explicitly specified in the inline schema compaction spec).
##########
processing/src/main/java/org/apache/druid/timeline/CompactionState.java:
##########
@@ -108,6 +112,12 @@ public GranularitySpec getGranularitySpec()
return granularitySpec;
}
+ @JsonProperty
Review Comment:
not meaningfully different in the sense that neither will result in
projections being built into the segment. I modified to coerce to empty so that
they are considered equivalent for comparison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
