github-advanced-security[bot] commented on code in PR #17803:
URL: https://github.com/apache/druid/pull/17803#discussion_r1996404820
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQInsertTest.java:
##########
@@ -466,6 +515,105 @@
}
+ @MethodSource("data")
+ @ParameterizedTest(name = "{index}:with context {0}")
+ public void testInsertOnExternalDataSourceWithCatalogProjections(String
contextName, Map<String, Object> context) throws IOException
Review Comment:
## Useless parameter
The parameter 'contextName' is never used.
[Show more
details](https://github.com/apache/druid/security/code-scanning/8721)
##########
server/src/test/java/org/apache/druid/server/compaction/CompactionStatusTest.java:
##########
@@ -105,41 +106,34 @@
@Test
public void
testFindPartitionsSpecFromConfigWithDeprecatedMaxRowsPerSegmentAndMaxTotalRowsReturnGivenValues()
{
- final DataSourceCompactionConfig config = new DataSourceCompactionConfig(
- "datasource",
- null,
- null,
- 100,
- null,
- new UserCompactionTaskQueryTuningConfig(
- null,
- null,
- null,
- 1000L,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null
- ),
- null,
- null,
- null,
- null,
- null,
- null,
- null
- );
+ final DataSourceCompactionConfig config =
+ InlineSchemaDataSourceCompactionConfig.builder()
+ .forDataSource("datasource")
+ .withMaxRowsPerSegment(100)
Review Comment:
## Deprecated method or constructor invocation
Invoking [Builder.withMaxRowsPerSegment](1) should be avoided because it has
been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/8724)
##########
server/src/test/java/org/apache/druid/client/indexing/ClientCompactionRunnerInfoTest.java:
##########
@@ -274,21 +275,18 @@
List<DimensionSchema> dimensions
)
{
- return new DataSourceCompactionConfig(
- "dataSource",
- null,
- 500L,
- 10000,
- new Period(3600),
- createTuningConfig(partitionsSpec),
- granularitySpec,
- new UserCompactionTaskDimensionsConfig(dimensions),
- metricsSpec,
- null,
- null,
- CompactionEngine.MSQ,
- context
- );
+ return InlineSchemaDataSourceCompactionConfig.builder()
+ .forDataSource("dataSource")
+
.withInputSegmentSizeBytes(500L)
+ .withMaxRowsPerSegment(10000)
Review Comment:
## Deprecated method or constructor invocation
Invoking [Builder.withMaxRowsPerSegment](1) should be avoided because it has
been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/8723)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
