adarshsanjeev commented on code in PR #17834:
URL: https://github.com/apache/druid/pull/17834#discussion_r2022157072
##########
server/src/main/java/org/apache/druid/server/compaction/BaseCandidateSearchPolicy.java:
##########
@@ -30,8 +30,7 @@
* Base implementation of {@link CompactionCandidateSearchPolicy} that can have
* a {@code priorityDatasource}.
*/
-public abstract class BaseCandidateSearchPolicy
- implements CompactionCandidateSearchPolicy, Comparator<CompactionCandidate>
Review Comment:
What's the reason to remove the comparator interface?
##########
indexing-service/src/main/java/org/apache/druid/indexing/compact/CompactionScheduler.java:
##########
@@ -44,24 +44,46 @@
*/
public interface CompactionScheduler
{
- void start();
+ void becomeLeader();
- void stop();
+ void stopBeingLeader();
Review Comment:
I see that the only case the scheduler stops is if it becomes leader, but
would it be better to leave it as the general `start()` and stop()`?
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/http/CompactionConfigHistoryResponse.java:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.indexing.overlord.http;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+import
org.apache.druid.server.coordinator.DataSourceCompactionConfigAuditEntry;
+
+import java.util.List;
+import java.util.Objects;
+
+public class CompactionConfigHistoryResponse
Review Comment:
Is this only used in tests? If so it could be moved to tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
