kfaraz commented on code in PR #17834:
URL: https://github.com/apache/druid/pull/17834#discussion_r2022260835
##########
server/src/main/java/org/apache/druid/server/compaction/BaseCandidateSearchPolicy.java:
##########
@@ -30,8 +30,7 @@
* Base implementation of {@link CompactionCandidateSearchPolicy} that can have
* a {@code priorityDatasource}.
*/
-public abstract class BaseCandidateSearchPolicy
- implements CompactionCandidateSearchPolicy, Comparator<CompactionCandidate>
Review Comment:
Keeping a plain `Comparator` made it difficult to find the places where the
comparison was actually being used.
So I removed this interface and just added a new method `compareCandidates`
instead of the usual `compare` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
