cecemei commented on PR #17774: URL: https://github.com/apache/druid/pull/17774#issuecomment-2798004863
> > TY this is looking good so far. I think the change to make the enforcer only have to deal with Restricted and Table makes sense. > > Addressed all your comments, and last round of unit/integration test looks good, could you please take a look again? Thx. Hey, this is ready for review again, a few things to look for from last round: - PolicyEnforcer class now take TableDataSource and ReferenceCountingSegment directly, this should make call stack more obvious. The exception is also thrown from enforcer. - The enforcer is injected into `QueryLifecycleFactory` and `TaskToolboxFactory`, and used in `withPolicies` and `createSegmentMapFunction`. Some file changes are purely because of the constructor now asks for enforcer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
