jtuglu-netflix commented on code in PR #17903:
URL: https://github.com/apache/druid/pull/17903#discussion_r2054415753
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScalerConfig.java:
##########
@@ -64,7 +65,8 @@ public LagBasedAutoScalerConfig(
@Nullable @JsonProperty("scaleOutStep") Integer scaleOutStep,
@Nullable @JsonProperty("enableTaskAutoScaler") Boolean
enableTaskAutoScaler,
@Nullable @JsonProperty("minTriggerScaleActionFrequencyMillis") Long
minTriggerScaleActionFrequencyMillis,
- @Nullable @JsonProperty("lagAggregate") AggregateFunction
lagAggregate
+ @Nullable @JsonProperty("lagAggregate") AggregateFunction
lagAggregate,
+ @Nullable @JsonProperty("useProportionalScaler") Boolean
useProportionalScaler
Review Comment:
Hmm. Given that the scalers exhibit different behavior (and use the configs
differently), I gated the difference behind a flag. Do we want to move this to
a separate class instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
