jtuglu-netflix commented on code in PR #17903:
URL: https://github.com/apache/druid/pull/17903#discussion_r2054890663
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScalerConfig.java:
##########
@@ -64,7 +65,8 @@ public LagBasedAutoScalerConfig(
@Nullable @JsonProperty("scaleOutStep") Integer scaleOutStep,
@Nullable @JsonProperty("enableTaskAutoScaler") Boolean
enableTaskAutoScaler,
@Nullable @JsonProperty("minTriggerScaleActionFrequencyMillis") Long
minTriggerScaleActionFrequencyMillis,
- @Nullable @JsonProperty("lagAggregate") AggregateFunction
lagAggregate
+ @Nullable @JsonProperty("lagAggregate") AggregateFunction
lagAggregate,
+ @Nullable @JsonProperty("useProportionalScaler") Boolean
useProportionalScaler
Review Comment:
Ah. This change just determines the task count proportional to the amount of
deviation from the desired aggregate lag threshold, so it's a variable step
versus a fixed step. I think ensuring tasks are assigned to partitions which
need it the most will be useful, but is unrelated to this change (that would
likely be at the supervisor itself I think).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
