jtuglu-netflix commented on PR #17903:
URL: https://github.com/apache/druid/pull/17903#issuecomment-2848522984

   > Sounds good, @jtuglu-netflix , please update this PR accordingly with both 
the changes. I will be happy to do a review.
   > 
   > For the "valid" task count logic, you could just update your 
`applyMinMaxCheck` method to perform the required checks.
   
   In this case, the scaling config parameters' meaning differ from what their 
documented use is. I'm wondering if this is something we'd want to incorporate 
into the current scaler, or perhaps create a new one altogether.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to