jtuglu-netflix commented on code in PR #17847:
URL: https://github.com/apache/druid/pull/17847#discussion_r2066777962
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/stats/TaskRealtimeMetricsMonitor.java:
##########
@@ -132,6 +132,19 @@ public boolean doMonitor(ServiceEmitter emitter)
emitter.emit(builder.setMetric("ingest/events/messageGap", messageGap));
}
+ final long minMessageGap = metrics.minMessageGap();
+ final long maxMessageGap = metrics.maxMessageGap();
+ // Best-effort way to ensure parity amongst emitted metrics
+ if (metrics.isMessageGapAggStatsEnabled()) {
+ if (minMessageGap != Long.MAX_VALUE) {
+ emitter.emit(builder.setMetric("ingest/events/minMessageGap",
minMessageGap));
Review Comment:
> And since these are only two new metrics reported in every metric emission
period, I think we should not need to add a new config.
These new metrics add overhead to the loop, not sure if that's something
people want to "opt-in" to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
