jtuglu-netflix commented on code in PR #18082: URL: https://github.com/apache/druid/pull/18082#discussion_r2140614231
########## extensions-contrib/rabbit-stream-indexing-service/src/main/java/org/apache/druid/indexing/rabbitstream/RabbitStreamIndexTask.java: ########## @@ -53,7 +55,9 @@ public RabbitStreamIndexTask( @JsonProperty("tuningConfig") RabbitStreamIndexTaskTuningConfig tuningConfig, @JsonProperty("ioConfig") RabbitStreamIndexTaskIOConfig ioConfig, @JsonProperty("context") Map<String, Object> context, - @JacksonInject ObjectMapper configMapper) + @JacksonInject ObjectMapper configMapper, + @JsonProperty("supervisorId") @Nullable String supervisorId Review Comment: Sure. I mainly did this because I saw previous commits did append only to the back of the params list (I assume it was mainly for avoiding issues with parameter mis-ordering). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org