jtuglu-netflix commented on code in PR #18082:
URL: https://github.com/apache/druid/pull/18082#discussion_r2140620917
##########
extensions-core/kafka-indexing-service/src/test/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisorTest.java:
##########
@@ -3282,7 +3283,7 @@ public void testStop()
{
EasyMock.expect(taskMaster.getTaskRunner()).andReturn(Optional.of(taskRunner)).anyTimes();
taskClient.close();
- taskRunner.unregisterListener(StringUtils.format("KafkaSupervisor-%s",
DATASOURCE));
Review Comment:
@kfaraz the problem with using the `KafkaSupervisor-.*` id for logs only is
that it's not just logs only. It actually uses the fake ID for binding task
listeners, etc. which I don't think is correct behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
