jtuglu-netflix commented on code in PR #18082:
URL: https://github.com/apache/druid/pull/18082#discussion_r2140627714
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorSpec.java:
##########
@@ -93,6 +96,7 @@ public SeekableStreamSupervisorSpec(
)
{
this.ingestionSchema = checkIngestionSchema(ingestionSchema);
+ this.id = Preconditions.checkNotNull(Configs.valueOrDefault(id,
ingestionSchema.getDataSchema().getDataSource()), "spec id cannot be null!");
Review Comment:
Why not? I feel like a better contract would be that subclasses provide
their id, and should that be null, that handling -> default coercion is done in
the root class. This prevents differing behavior between subclasses among other
things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
