kfaraz commented on code in PR #18082:
URL: https://github.com/apache/druid/pull/18082#discussion_r2141820732
##########
extensions-contrib/rabbit-stream-indexing-service/src/main/java/org/apache/druid/indexing/rabbitstream/supervisor/RabbitStreamSupervisorSpec.java:
##########
@@ -63,6 +63,7 @@ public RabbitStreamSupervisorSpec(
@JacksonInject SupervisorStateManagerConfig supervisorStateManagerConfig)
{
super(
+ id,
Review Comment:
Ah, okay, the logging key thing.
Let's remove that from the constructor args as it is sure to cause confusion
with the actual supervisor id.
Since this is a non identifying property, it would fall in the category you
mentioned earlier where we can
have the super class handle the common logic.
We can build the logging key in one of two ways inside the
`SeekableStreamSupervisor` constructor:
1. `this.loggingKey = StringUtils.format("%s-%s",
this.getClass().getSimpleName(), spec.getId())`
2. OR Add an abstract `getLoggingKey` method and implement it in the
sub-classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
