jtuglu-netflix commented on code in PR #18082:
URL: https://github.com/apache/druid/pull/18082#discussion_r2140722267
##########
server/src/main/java/org/apache/druid/metadata/SQLMetadataConnector.java:
##########
@@ -251,29 +251,47 @@ public void createTable(final String tableName, final
Iterable<String> sql)
/**
* Execute the desired ALTER statement on the desired table
*
- * @param tableName The name of the table being altered
- * @param sql ALTER statment to be executed
+ * @param tableName The name of the table being altered
+ * @param sql ALTER statements to be executed
+ * @param useTransaction Whether to use a transaction for this operation
*/
- private void alterTable(final String tableName, final Iterable<String> sql)
+ private void alterTable(final String tableName, final Iterable<String> sql,
final boolean useTransaction)
{
try {
retryWithHandle(handle -> {
if (tableExists(handle, tableName)) {
- final Batch batch = handle.createBatch();
- for (String s : sql) {
- log.info("Altering table[%s], with command: %s", tableName, s);
Review Comment:
Had removed mainly to prevent excessive logging within a transaction – I'll
add back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
