jtuglu-netflix commented on code in PR #18082:
URL: https://github.com/apache/druid/pull/18082#discussion_r2141914771
##########
integration-tests/src/test/java/org/apache/druid/tests/indexer/AbstractStreamIndexingTest.java:
##########
@@ -170,8 +172,7 @@ protected static List<String> listDataFormatResources()
throws IOException
{
return listResources(DATA_RESOURCE_ROOT)
.stream()
- .filter(resource -> !SUPERVISOR_SPEC_TEMPLATE_FILE.equals(resource))
- .filter(resource ->
!SUPERVISOR_WITH_AUTOSCALER_SPEC_TEMPLATE_FILE.equals(resource))
+ .filter(r -> !r.endsWith(".json")) // filter out top-level spec files
Review Comment:
I noticed this when I was testing all data format types locally for safety
for the multi supervisor test (instead of just json). It scans the top-level
directory for all data format folders, then uses these folders later to find
the serializers, etc. There are now multiple json spec templates in that root
directory (not just `SUPERVISOR_SPEC_TEMPLATE_FILE` and
`SUPERVISOR_WITH_AUTOSCALER_SPEC_TEMPLATE_FILE`). This change ensures that any
top-level json files are ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
