kfaraz commented on PR #18082: URL: https://github.com/apache/druid/pull/18082#issuecomment-2969317930
But since we are doing the ALTERs in a transaction, I guess we should be okay 🤷🏻 . Downgrading after that would essentially require a revert of the ALTERs we do this in patch: - Ensure that there is only one record per datasource - Get rid of the extra supervisors for any datasource - DROP the index on supervisor_id and DROP that column - ADD the PRIMARY KEY on datasource I think this might become simpler if the new PRIMARY KEY is a composite on the two columns (dataSource + supervisor_id). Then, we wouldn't need to do any DB migration while doing a downgrade. @jtuglu-netflix , @maytasm , thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
