kfaraz commented on code in PR #18082:
URL: https://github.com/apache/druid/pull/18082#discussion_r2141811454
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/ResetDataSourceMetadataAction.java:
##########
@@ -26,14 +26,17 @@
public class ResetDataSourceMetadataAction implements TaskAction<Boolean>
{
+ private final String supervisorId;
private final String dataSource;
private final DataSourceMetadata resetMetadata;
public ResetDataSourceMetadataAction(
+ @JsonProperty("supervisorId") String supervisorId,
@JsonProperty("dataSource") String dataSource,
Review Comment:
Sure, that sounds reasonable. Whenever we make that change, we would need to
add a validation in the constructor that at least one of the two fields is
non-null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]