jtuglu-netflix commented on code in PR #18082:
URL: https://github.com/apache/druid/pull/18082#discussion_r2151333971
##########
docs/operations/metrics.md:
##########
@@ -225,11 +225,11 @@ These metrics apply to the [Kafka indexing
service](../ingestion/kafka-ingestion
|Metric|Description|Dimensions|Normal value|
|------|-----------|----------|------------|
-|`ingest/kafka/lag`|Total lag between the offsets consumed by the Kafka
indexing tasks and latest offsets in Kafka brokers across all partitions.
Minimum emission period for this metric is a minute.|`dataSource`, `stream`,
`tags`|Greater than 0, should not be a very high number. |
-|`ingest/kafka/maxLag`|Max lag between the offsets consumed by the Kafka
indexing tasks and latest offsets in Kafka brokers across all partitions.
Minimum emission period for this metric is a minute.|`dataSource`, `stream`,
`tags`|Greater than 0, should not be a very high number. |
-|`ingest/kafka/avgLag`|Average lag between the offsets consumed by the Kafka
indexing tasks and latest offsets in Kafka brokers across all partitions.
Minimum emission period for this metric is a minute.|`dataSource`, `stream`,
`tags`|Greater than 0, should not be a very high number. |
-|`ingest/kafka/partitionLag`|Partition-wise lag between the offsets consumed
by the Kafka indexing tasks and latest offsets in Kafka brokers. Minimum
emission period for this metric is a minute.|`dataSource`, `stream`,
`partition`, `tags`|Greater than 0, should not be a very high number. |
-|`ingest/kafka/fetchOffsets/time`|Total time (in milliseconds) taken to fetch
and update the latest offsets from Kafka stream and the ingestion
tasks.|`dataSource`, `taskId`, `taskType`, `groupId`, `tags`|Generally a few
seconds at most.|
+|`ingest/kafka/lag`|Total lag between the offsets consumed by the Kafka
indexing tasks and latest offsets in Kafka brokers across all partitions.
Minimum emission period for this metric is a minute.|`supervisorId`,
`dataSource`, `stream`, `tags`|Greater than 0, should not be a very high
number. |
Review Comment:
Wouldn't users need to write their metrics queries in a certain way to
account for this then?
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -4520,6 +4532,7 @@ protected void emitNoticeProcessTime(String noticeType,
long timeInMillis)
emitter.emit(
ServiceMetricEvent.builder()
.setDimension("noticeType", noticeType)
+ .setDimension(DruidMetrics.SUPERVISOR_ID,
supervisorId)
Review Comment:
See below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
