jtuglu-netflix commented on code in PR #18082:
URL: https://github.com/apache/druid/pull/18082#discussion_r2151354479
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentTransactionalAppendAction.java:
##########
@@ -95,13 +99,28 @@ private SegmentTransactionalAppendAction(
this.startMetadata = startMetadata;
this.endMetadata = endMetadata;
+ if (supervisorId == null && !segments.isEmpty()) {
Review Comment:
I agree it doesn't make sense with empty set of segments. If this were to
happen, this check would already be performed later on in the
IndexerMetadataCoordinator. I just added this so that way we can guarantee a
non-null `supervisorId` if it's not specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
