jtuglu-netflix commented on code in PR #18082:
URL: https://github.com/apache/druid/pull/18082#discussion_r2151361060
##########
server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java:
##########
@@ -405,47 +409,47 @@ SegmentPublishResult commitReplaceSegments(
);
/**
- * Retrieves data source's metadata from the metadata store. Returns null if
there is no metadata.
+ * Retrieves {@link DataSourceMetadata} entry for {@code supervisorId} from
the metadata store. Returns null if there is no metadata.
*/
- @Nullable DataSourceMetadata retrieveDataSourceMetadata(String dataSource);
+ @Nullable DataSourceMetadata retrieveDataSourceMetadata(String supervisorId);
Review Comment:
> Isn't the dataSource name always the supervisorId for a
MaterializedViewSupervisor
It is.
> Can it use some other supervisor id too?
Not without changes to the `DerivativeDatasourceManager` to not treat the
value in the `dataSource` column as datasources, but instead supervisor ID.
##########
server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java:
##########
@@ -405,47 +409,47 @@ SegmentPublishResult commitReplaceSegments(
);
/**
- * Retrieves data source's metadata from the metadata store. Returns null if
there is no metadata.
+ * Retrieves {@link DataSourceMetadata} entry for {@code supervisorId} from
the metadata store. Returns null if there is no metadata.
*/
- @Nullable DataSourceMetadata retrieveDataSourceMetadata(String dataSource);
+ @Nullable DataSourceMetadata retrieveDataSourceMetadata(String supervisorId);
Review Comment:
> Isn't the dataSource name always the supervisorId for a
MaterializedViewSupervisor
It is.
> Can it use some other supervisor id too?
Not without changes to the `DerivativeDatasourceManager` to not treat the
value in the `dataSource` column as datasources, but instead supervisor ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
