gianm commented on PR #18144: URL: https://github.com/apache/druid/pull/18144#issuecomment-2998296799
> I feel like the `result` and the `outpuchannel` should be more closer to eachother... > there are multiple classes which has an `And` in their name. I feel like some concept is missing...as those are essentially try to repack those into a single object - I suspect that the fact that `Future`-s are used doesn't make it easier either. I pushed a couple commits resolving merge conflicts, and also adding various javadocs that I hope clarifies the usage of the "result" and "channels" concepts. The main reason for all the future-stuff is that the "result" is available only after all processing is fully complete, whereas the "output channels" may be available for reading prior to processing being complete (when data is streamed between two concurrently-running stages). Thank you for the review, I'll merge after the tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
