gianm commented on code in PR #18144:
URL: https://github.com/apache/druid/pull/18144#discussion_r2150887908
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/RunWorkOrder.java:
##########
@@ -215,23 +172,11 @@ public void startAsync()
throw new ISE("Cannot start from state[%s]", state);
}
- final StageDefinition stageDef = workOrder.getStageDefinition();
-
try {
exec.registerCancellationId(cancellationId);
- makeInputSliceReader();
- makeWorkOutputChannelFactory();
- makeShuffleOutputChannelFactory();
- makeAndRunWorkProcessors();
-
- if (stageDef.doesShuffle()) {
- makeAndRunShuffleProcessors();
- } else {
- // No shuffling: work output _is_ stage output. Retain read-only
versions to reduce memory footprint.
- stageOutputChannelsFuture =
-
Futures.immediateFuture(workResultAndOutputChannels.getOutputChannels().readOnly());
- }
-
+ initInputSliceReader();
Review Comment:
I just deleted this call. Only the one inside `makeExecutionContext` was
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
