abhishekrb19 commented on code in PR #18169: URL: https://github.com/apache/druid/pull/18169#discussion_r2162777897
########## processing/src/test/java/org/apache/druid/segment/nested/StructuredDataTest.java: ########## @@ -95,6 +95,18 @@ public void testCompareTo() } + @Test + public void testCompareToWithDifferentJSONOrder() Review Comment: Since this change introduces a subtle behavioral difference in how JSON columns are ingested or queried, could we also include a SQL query test? I think one option could be to add some rows with similar values we have here to a new column in `CalciteNestedDataQueryTest` and run a `GROUP BY` on the added column. Prior to the sorting behavior in this patch, the `GROUP BY` results with "duplicate values" would differ but now the results would be more inline with mysql with sorted keys? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
