aho135 commented on code in PR #18169: URL: https://github.com/apache/druid/pull/18169#discussion_r2164463138
########## processing/src/test/java/org/apache/druid/segment/nested/StructuredDataTest.java: ########## @@ -95,6 +95,18 @@ public void testCompareTo() } + @Test + public void testCompareToWithDifferentJSONOrder() Review Comment: Thanks for the review @abhishekrb19! This current implementation only sorts the keys prior to hash computation, but key order remains the same. This is the minimal change to fix the transitivity bug. If we want to align with MySQL and Postgres jsonb then I can make these changes on the ColumnSerializerUtils.SMILE_MAPPER The current behavior does align with Postgres json. What do you think the preferred behavior should be? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
