aho135 commented on code in PR #18169:
URL: https://github.com/apache/druid/pull/18169#discussion_r2176088973


##########
processing/src/test/java/org/apache/druid/segment/nested/StructuredDataTest.java:
##########
@@ -95,6 +95,18 @@ public void testCompareTo()
 
   }
 
+  @Test
+  public void testCompareToWithDifferentJSONOrder()

Review Comment:
   One way I was thinking to do this would be to add a new property in 
NestedDataColumnSchema (e.g. sortMapKeys). Then we can pass this value to 
StructuredData so it knows whether it needs to sort map keys before the hash 
computation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to