kgyrtkirk commented on code in PR #18121:
URL: https://github.com/apache/druid/pull/18121#discussion_r2176904747
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerContext.java:
##########
@@ -33,17 +33,23 @@
import org.apache.druid.server.DruidNode;
import java.io.File;
+import java.util.Map;
/**
* Context used by multi-stage query controllers. Useful because it allows
test fixtures to provide their own
* implementations.
*/
public interface ControllerContext
{
+ /**
+ * Query ID for this context.
+ */
+ String queryId();
Review Comment:
we already have a lot of queryId-s this method will just increase the
confusion - one implementation of this method returns `DART_QUERY_ID` and the
other something else
right now all callsites seem to be inside the implementations of this
interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
