adarshsanjeev commented on code in PR #18121:
URL: https://github.com/apache/druid/pull/18121#discussion_r2158302281
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -553,11 +555,17 @@ private MSQTaskReportPayload runInternal(final
QueryListener queryListener, fina
countersSnapshot,
null
);
+ emitQueryMetrics(stopwatch);
// Emit summary metrics
emitSummaryMetrics(msqTaskReportPayload, querySpec);
return msqTaskReportPayload;
}
+ private void emitQueryMetrics(Stopwatch stopwatch)
+ {
+ context.emitMetric("query/time", stopwatch.millisElapsed());
Review Comment:
I wanted to call something out, the metrics that were already being reported
already had a `dataSource` dimension, which is the `task.getDataSource()`. To
keep it compatible, should these new query specific dimensions like
`dataSource` and `interval` be only for the new metrics added by this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
