HiveQA commented on code in PR #18121:
URL: https://github.com/apache/druid/pull/18121#discussion_r2177217999
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -553,11 +554,31 @@ private MSQTaskReportPayload runInternal(final
QueryListener queryListener, fina
countersSnapshot,
null
);
- // Emit summary metrics
+ // Emit metrics
+ emitQueryMetrics(queryDef, taskStateForReport.isSuccess());
emitSummaryMetrics(msqTaskReportPayload, querySpec);
return msqTaskReportPayload;
}
+ private void emitQueryMetrics(@Nullable final QueryDefinition queryDef,
final boolean success)
+ {
+ final Set<String> datasources = new HashSet<>();
+ final Set<Interval> intervals = new HashSet<>();
+ if (queryDef != null) {
+ for (StageDefinition stageDefinition : queryDef.getStageDefinitions()) {
+ datasources.addAll(MSQMetricUtils.getDatasources(stageDefinition));
+ intervals.addAll(MSQMetricUtils.getIntervals(stageDefinition));
+ }
+ }
+
+ long startTime =
DateTimeUtils.getInstantMillis(MultiStageQueryContext.getStartTime(querySpec.getContext()));
+ context.emitMetric(
+ "query/time",
+ MSQMetricUtils.createQueryMetricDimensions(datasources, intervals,
success),
+ startTime - System.currentTimeMillis()
Review Comment:
I still feel that the `context#emitMetric` method is odd; it could be
something like:
```
MsqServiceMetricEventBuilder metricBuilder = new
MsqServiceMetricEventBuilder(querySpec);
metricBuilder.setDimension(DruidMetrics.DATASOURCE,
DefaultQueryMetrics.getTableNamesAsString(datasources));
metricBuilder.setDimension(DruidMetrics.INTERVAL,
DefaultQueryMetrics.getIntervalsAsStringArray(intervals));
metricBuilder.setDimension(DruidMetrics.DURATION,
BaseQuery.calculateDuration(intervals));
metricBuilder.setDimension(DruidMetrics.SUCCESS, success);
metricBuilder.setMetric("query/time", startTime -
System.currentTimeMillis());
context.getEmitter().emit(metricBuilder);
```
probably `MsqServiceMetricEventBuilder` could also provide a more natural
home for those static methods which could become instance methods
..or alter the signature of `context#emitrMetric` to
`context#emit(metricBuilder)` ? so that the context could still
add stuff if it wants - but the caller has the control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
