jtuglu1 commented on code in PR #18463:
URL: https://github.com/apache/druid/pull/18463#discussion_r2314496339
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -524,7 +523,9 @@ public List<SegmentAllocateResult> allocateSegments(
/**
* Marks the segment allocation as failed if the underlying task is not
active.
+ * Should be called only while holding the {@code giant} lock.
*/
+ @GuardedBy("giant")
Review Comment:
`@GuardedBy` is function-based and not block-based. In a few places in
`GlobalTaskLockbox` we rely on methods doing internal (block-based) locking of
giant lock. The `@GuardedBy` cannot "look" inside the body of the function to
ensure the lock is held, so it reports some of these codepaths as uncovered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
