kfaraz commented on code in PR #18463:
URL: https://github.com/apache/druid/pull/18463#discussion_r2314832696


##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -567,6 +569,10 @@ private TaskLockPosse createOrFindLockPosse(LockRequest 
request, Task task, bool
     giant.lock();
 
     try {
+      if (!activeTasks.contains(task.getId())) {

Review Comment:
   No, I guess it makes sense. Method `tryLock` is already doing this. So maybe 
let's put it in a common method `ensureActiveTask()`.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to