kfaraz commented on code in PR #18463:
URL: https://github.com/apache/druid/pull/18463#discussion_r2314829713
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -524,7 +523,9 @@ public List<SegmentAllocateResult> allocateSegments(
/**
* Marks the segment allocation as failed if the underlying task is not
active.
+ * Should be called only while holding the {@code giant} lock.
*/
+ @GuardedBy("giant")
Review Comment:
No, I meant the `private final Set<String> activeTasks = new HashSet<>();`
inside `TaskLockbox` class should be annotated with guarded by.
The only uncovered path would be `getActiveTasks()` which ~we should fix up~
you seem to have already fixed up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
