capistrant commented on code in PR #18424:
URL: https://github.com/apache/druid/pull/18424#discussion_r2317324235
##########
indexing-hadoop/src/main/java/org/apache/druid/indexer/JobHelper.java:
##########
@@ -155,7 +155,8 @@ public static void setupClasspath(
for (String jarFilePath : jarFiles) {
final File jarFile = new File(jarFilePath);
- if (jarFile.getName().endsWith(".jar")) {
+ // Keep Druid jetty jars out of the classpath. They are not runnable in
the < 17 hadoop java runtime
+ if (jarFile.getName().endsWith(".jar") &&
!jarFile.getName().contains("jetty")) {
Review Comment:
I agree that this is suboptimal. I was in the "lets see if we can make it
work" mindset. Maybe there is a more clean approach to filtering the jetty jars
out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
