capistrant commented on code in PR #18424: URL: https://github.com/apache/druid/pull/18424#discussion_r2342202007
########## docs/operations/java.md: ########## @@ -43,26 +43,18 @@ Druid relies on the environment variables `JAVA_HOME` or `DRUID_JAVA_HOME` to fi ## Garbage collection In general, the project team recommends using the G1 collector with default settings. This is the default collector in -Java 11 and 17. +Java 17. Garbage collector selection and tuning is a form of sport in the Java community. There may be situations where adjusting garbage collection configuration improves or worsens performance. The project team's guidance is that most people do not need to stray away from G1 with default settings. ## Strong encapsulation -Java 9 and beyond (including Java 11 and 17) include the capability for +Java 9 and beyond (including Java 17) include the capability for [strong encapsulation](https://dev.java/learn/strong-encapsulation-\(of-jdk-internals\)/) of internal JDK APIs. Druid uses certain internal JDK APIs, which must be added to `--add-exports` and `--add-opens` on the Java command line. -On Java 11, if these parameters are not included, you will see warnings like the following: - -``` -WARNING: An illegal reflective access operation has occurred -WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations -WARNING: All illegal access operations will be denied in a future release -``` - Review Comment: ehh that was probably me just seeing Java 11 and not Java 11+ and hitting delete. I'll confirm it is still there and add back without the explicit java 11 part -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
