capistrant commented on code in PR #18424:
URL: https://github.com/apache/druid/pull/18424#discussion_r2359488248
##########
server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java:
##########
@@ -467,25 +468,21 @@ public void stop()
server.setErrorHandler(new ErrorHandler()
{
@Override
- public boolean isShowServlet()
- {
- return false;
- }
-
- @Override
- public void handle(
- String target,
+ public boolean handle(
Request baseRequest,
- HttpServletRequest request,
- HttpServletResponse response
- ) throws IOException, ServletException
+ Response response,
+ Callback callback
+ ) throws Exception
{
- request.setAttribute(RequestDispatcher.ERROR_EXCEPTION, null);
- super.handle(target, baseRequest, request, response);
+ baseRequest.setAttribute(RequestDispatcher.ERROR_EXCEPTION, null);
+ return super.handle(baseRequest, response, callback);
}
});
}
+ log.info("Configuraing Jetty Request log for server");
Review Comment:
likely not! Was a convenience for me to grep across service logs during some
functional testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
