capistrant commented on code in PR #18424:
URL: https://github.com/apache/druid/pull/18424#discussion_r2342415211
##########
server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerInitUtils.java:
##########
@@ -109,15 +109,6 @@ public static void addFilters(ServletContextHandler
handler, Set<? extends Servl
}
}
- public static Handler getJettyRequestLogHandler()
- {
- // Ref:
http://www.eclipse.org/jetty/documentation/9.2.6.v20141205/configuring-jetty-request-logs.html
- RequestLogHandler requestLogHandler = new RequestLogHandler();
- requestLogHandler.setRequestLog(new JettyRequestLog());
-
- return requestLogHandler;
- }
Review Comment:
💯 definitely a miss by not properly migrating this. I think initialization
in JettyServerModule is the right spot? Confirmed that it was wired up across
all druid services in my Docker env after moving it in latest commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
