GabrielCWT commented on code in PR #18547:
URL: https://github.com/apache/druid/pull/18547#discussion_r2374565750
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java:
##########
@@ -180,6 +180,7 @@ public class SystemSchema extends AbstractSchema
.add("max_size", ColumnType.LONG)
.add("is_leader", ColumnType.LONG)
.add("start_time", ColumnType.STRING)
+ .add("labels", ColumnType.NESTED_DATA)
Review Comment:
I will open up an issue for a possible refactor to implement
`ProjectableFilterableTable`. It would be useful if the number of fields
requiring serialising increases. For now I will stick with what was written
originally.
> If we're going to optimize the serialization in future, my suggestion is
to cache the serialized value in the DruidNode.
This was also an optimisation I was thinking of. What are your thoughts?
@kfaraz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
