kfaraz commented on code in PR #18547:
URL: https://github.com/apache/druid/pull/18547#discussion_r2374792405
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java:
##########
@@ -180,6 +180,7 @@ public class SystemSchema extends AbstractSchema
.add("max_size", ColumnType.LONG)
.add("is_leader", ColumnType.LONG)
.add("start_time", ColumnType.STRING)
+ .add("labels", ColumnType.NESTED_DATA)
Review Comment:
> If we're going to optimize the serialization in future, my suggestion is
to cache the serialized value in the DruidNode.
Yeah, I suppose that is possible by passing a `@JacksonInject ObjectMapper`
into the `DruidNode` constructor.
But it really seems unnecessary at this point.
@FrankChen021 , as you mention, serializing a small map is not a costly
operation, we need not worry about that optimization right now.
I should think that there are many more costlier serialization steps
involved in a single `SELECT * FROM sys.servers` query.
If the labels map becomes large, then we have other problems as mentioned
before anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
