GabrielCWT commented on PR #18547: URL: https://github.com/apache/druid/pull/18547#issuecomment-3322114801
> My only concern was with adding a new type of free-form info to `DruidNode` since it is primarily used for service discovery. There can be issues with Zookeeper if a node ends up having very large label values, but I suppose it is not very likely to happen and would be a configuration issue rather than a code issue anyway. This was indeed one of my concerns as well but right now the use case will be a maximum of 2-3 values. As you mentioned, an absurdly large number of label values would be a configuration issue. > The alternative would be to just bind it to a completely new config object and then it would be served over the `/status/properties` API but then you wouldn't be able to display it on the web-console. The main idea is for it to be visible on the web-console and therefore I think sticking to the current implementation is better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
