FrankChen021 commented on code in PR #18547:
URL: https://github.com/apache/druid/pull/18547#discussion_r2374559496
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java:
##########
@@ -180,6 +180,7 @@ public class SystemSchema extends AbstractSchema
.add("max_size", ColumnType.LONG)
.add("is_leader", ColumnType.LONG)
.add("start_time", ColumnType.STRING)
+ .add("labels", ColumnType.NESTED_DATA)
Review Comment:
I don't think this optimization helps. because on the web-console, the
`label` is always selected, this is the most scenario that `sys.server` table
is queried.
Considering the number of servers is not very large(and even the number is
huge, at the early phase of this feature, it may not be widely used), the
serialization here might NOT be a problem.
If we're going to optimize the serialization in future, my suggestion is to
cache the serialized value in the `DruidNode`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
