Shiyang-Zhao commented on PR #18621: URL: https://github.com/apache/druid/pull/18621#issuecomment-3399646065
Hi @kfaraz I wasn’t able to find a CI build that currently fails due to this issue, but the ordering of a `HashSet` (which is a `@JsonProperty` in this case) is not guaranteed. This can potentially lead to nondeterministic behavior in the future, since `SeekableStreamSupervisor.generateSequenceName()` computes a hash code based on the serialized JSON. A `LinkedHashSet` was used since modifying the field `dimensionExclusions` would require changes to other parts of the code that rely on set operations. For example, `dimensionExclusions` is used in `verify` on line 293 in `DimensionsSpec.java` to perform a set intersection. Would you still like me to change it to a `List`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
