kfaraz commented on PR #18621: URL: https://github.com/apache/druid/pull/18621#issuecomment-3449351918
Thanks for sharing the details, @Shiyang-Zhao ! > I could look into mitigating this directly within the test code, but given that the sequence hash is computed within the code under test, there may be limited options. Would you still like me to proceed? Do you mean we would be able to handle the discrepancies only within the test and not in the production code? If yes, then I don't think that would add a lot of value. Ideally, we would want a test to prove that running production supervisors will not be affected. If the change in this PR is certain or even likely to affect running supervisors when the Overlord restarts, we would need to rethink the solution. But as you mention, since the order remains the same when running in ONE mode, I think we can live with the status quo for now. We could update this PR to just leave a comment in the relevant code. Hope that makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
