Shiyang-Zhao commented on PR #18621: URL: https://github.com/apache/druid/pull/18621#issuecomment-3440063873
Hi @kfaraz , Apologies for the delayed response. I was able to identify that the test is indeed flaky when using Nondex (https://github.com/TestingResearchIllinois/NonDex), which randomizes the iteration order of unordered collections such as Set. Specifically, the testIsTaskCurrent() test failed under FULL mode, where the iteration order is randomized on every collection traversal. However, when running in ONE mode—where the iteration order is randomized only once per JVM instance—the test passed consistently. This behavior occurs because the generateSequenceName method depends on the ordering of the serialized JSON representation of the dimensionExclusions set. In ONE mode, the ordering remains stable across calls, resulting in consistent sequence names. While this makes it difficult to reproduce the failure simply by adding elements to the set, it’s worth noting that since the Set interface provides no ordering guarantees, this could still occur under certain conditions or in future JDK versions. Regarding your concern about upgrading the Overlord and potentially affecting currently running supervisors, I could look into mitigating this directly within the test code, but given that the sequence hash is computed within the code under test, there may be limited options. Would you still like me to proceed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
