clintropolis commented on code in PR #18722:
URL: https://github.com/apache/druid/pull/18722#discussion_r2600082898
##########
processing/src/main/java/org/apache/druid/segment/nested/GlobalDictionaryEncodedFieldColumnWriter.java:
##########
@@ -187,7 +189,11 @@ long getSerializedColumnSize() throws IOException
* Defines how to write the column, including the dictionary id column,
along with any additional columns
* such as the long or double value column as type appropriate.
*/
- abstract void writeColumnTo(WritableByteChannel channel, SegmentFileBuilder
fileBuilder) throws IOException;
+ void writeColumnTo(WritableByteChannel channel, SegmentFileBuilder
fileBuilder) throws IOException
+ {
+ writeLongAndDoubleColumnLength(channel, 0, 0);
+ encodedValueSerializer.writeTo(channel, fileBuilder);
+ }
Review Comment:
why remove the abstraction here? iirc I made it abstract on purpose to
ensure that every field implements this method since it is pretty important to
be correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
