clintropolis commented on code in PR #18722:
URL: https://github.com/apache/druid/pull/18722#discussion_r2608052712
##########
processing/src/main/java/org/apache/druid/segment/nested/NestedCommonFormatColumnFormatSpec.java:
##########
@@ -172,14 +184,18 @@ public static NestedCommonFormatColumnFormatSpec
getEffectiveFormatSpec(
private final CompressionStrategy doubleColumnCompression;
@Nullable
private final BitmapSerdeFactory bitmapEncoding;
+ @Nullable
+ private final BitmapIndexEncodingStrategy numericFieldsBitmapIndexEncoding;
@JsonCreator
public NestedCommonFormatColumnFormatSpec(
@JsonProperty("objectFieldsDictionaryEncoding") @Nullable
StringEncodingStrategy objectFieldsDictionaryEncoding,
+ @JsonProperty("numericFieldsBitmapIndexEncoding") @Nullable
BitmapIndexEncodingStrategy numericFieldsBitmapIndexEncoding,
Review Comment:
i was wanting long and double to be separate so we could support use cases
where json has fields with long values that are used as dimensions but doubles
as measures, before we implement per field customization. I think I was
imagining per field customization would allow partial declaration, so that it
could fall back to the per type default if an explicit configuration was not
specified for a given field, so it would still be nice to be able to control
them separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
