cecemei commented on code in PR #18722:
URL: https://github.com/apache/druid/pull/18722#discussion_r2611949543


##########
processing/src/main/java/org/apache/druid/segment/nested/NestedCommonFormatColumnFormatSpec.java:
##########
@@ -172,14 +184,18 @@ public static NestedCommonFormatColumnFormatSpec 
getEffectiveFormatSpec(
   private final CompressionStrategy doubleColumnCompression;
   @Nullable
   private final BitmapSerdeFactory bitmapEncoding;
+  @Nullable
+  private final BitmapIndexEncodingStrategy numericFieldsBitmapIndexEncoding;
 
   @JsonCreator
   public NestedCommonFormatColumnFormatSpec(
       @JsonProperty("objectFieldsDictionaryEncoding") @Nullable 
StringEncodingStrategy objectFieldsDictionaryEncoding,
+      @JsonProperty("numericFieldsBitmapIndexEncoding") @Nullable 
BitmapIndexEncodingStrategy numericFieldsBitmapIndexEncoding,

Review Comment:
   added the `longFieldBitmapIndex` and `doubleFieldBitmapIndex` config, looks 
like 134 bytes (for both config) per field increase in the overhead. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to