GWphua commented on code in PR #18731:
URL: https://github.com/apache/druid/pull/18731#discussion_r2689583479
##########
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/ByteBufferIntList.java:
##########
@@ -71,4 +72,9 @@ public void reset()
{
numElements = 0;
Review Comment:
The `ByteBufferIntList` in BufferHashGrouper should by all means be `final`,
but we cannot make it so because it is only initialized when
`BufferHashGrouper#init` is called.
Here I am intending to record the maximum usage for the entire
`BufferHashGrouper`'s lifecycle. So, reset will not set the max usage to 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
