GWphua commented on code in PR #18731:
URL: https://github.com/apache/druid/pull/18731#discussion_r2689698589
##########
processing/src/main/java/org/apache/druid/query/groupby/epinephelinae/ByteBufferHashTable.java:
##########
@@ -381,6 +387,16 @@ public int getGrowthCount()
return growthCount;
}
+ protected void updateMaxTableBufferUsage()
+ {
+ maxTableBufferUsage = Math.max(maxTableBufferUsage,
tableBuffer.capacity());
Review Comment:
You are right about the current metric reporting the allocation.
I relooked the implementation, and found that maybe we can better estimate
the ByteBufferHashTable. Since the ByteBufferHashTable is an open-addressing
hash table, we can use the number of elements in table (size) * space taken up
per bucket (bucketSizeWithHash) to estimate the usage in bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
